Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #861 serde::Deserialize impl for Url prints confusing error message #862

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #861 serde::Deserialize impl for Url prints confusing error message #862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5056a0a
Fix #861 serde::Deserialize impl for Url prints confusing error message
justy777 Jul 23, 2023
14b0814
Merge branch 'master' into master
justy777 Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions url/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2778,16 +2778,15 @@ impl<'de> serde::Deserialize<'de> for Url {
type Value = Url;

fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
formatter.write_str("a string representing an URL")
formatter.write_str("a string representing a URL")
}

fn visit_str<E>(self, s: &str) -> Result<Self::Value, E>
where
E: Error,
{
Url::parse(s).map_err(|err| {
let err_s = format!("{}", err);
Error::invalid_value(Unexpected::Str(s), &err_s.as_str())
Url::parse(s).map_err(|_| {
Error::invalid_value(Unexpected::Str(s), &self)
})
}
}
Expand Down