Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fuzz crate #660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update fuzz crate #660

wants to merge 1 commit into from

Conversation

e00E
Copy link
Contributor

@e00E e00E commented Dec 10, 2020

Following the instructions from the fuzzing book the fuzz crate has been
recreated.
I renamed the file because it makes it slightly more clear what it does.
Putting the second parse and the assert on different lines gives better
panic messages because it makes it easier to distinguish whether the
unwrapping or the assert failed.

To run the fuzzer:

cargo +nightly install cargo-fuzz
cd url
cargo +nightly fuzz run parse

@djc
Copy link
Contributor

djc commented Dec 13, 2020

Can you change your commits to (a) leave the username/password commit out of this PR, and (b) tell git about the rename of the fuzzing module? That would make it easier to confidently review this.

@e00E
Copy link
Contributor Author

e00E commented Dec 14, 2020

Removed the debug commit and removed the fuzz target rename too.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@valenting
Copy link
Collaborator

I think this target is being currently fuzzed.
See google/oss-fuzz#3948

@DavidKorczynski does this change look OK to you?

@e00E
Copy link
Contributor Author

e00E commented Dec 15, 2020

If this fuzz target is supposed to be run already then something is going wrong with that process seeing as me manually running it found a failing test case in a couple of seconds.

@DavidKorczynski
Copy link
Contributor

The current fuzzer is being run by OSS-Fuzz and I can see there is also an assert bug listed on OSS-Fuzz. So I guess the question is whether the changes updated by @e00E are interesting to have - I think that's up to the maintainers to decide?

To be clear though, the fuzzer will continue to be run by OSS-Fuzz if these gets merged in.

Following the instructions from the fuzzing book the fuzz crate has been
recreated.
Putting the second parse and the assert on different lines gives better
panic messages because it makes it easier to distinguish whether the
unwrapping or the assert failed.
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92f356e) 81.70% compared to head (55e65d0) 81.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   81.70%   81.67%   -0.03%     
==========================================
  Files          20       20              
  Lines        3547     3547              
==========================================
- Hits         2898     2897       -1     
- Misses        649      650       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants