Fix #861 serde::Deserialize impl for Url prints confusing error message

servo · Oct 4, 2023 · 5056a0a · 5056a0a
1 parent a08aa2c
commit 5056a0a
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/url/src/lib.rs b/url/src/lib.rs
@@ -2775,16 +2775,15 @@ impl<'de> serde::Deserialize<'de> for Url {
             type Value = Url;
 
             fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
-                formatter.write_str("a string representing an URL")
+                formatter.write_str("a string representing a URL")
             }
 
             fn visit_str<E>(self, s: &str) -> Result<Self::Value, E>
             where
                 E: Error,
             {
-                Url::parse(s).map_err(|err| {
-                    let err_s = format!("{}", err);
-                    Error::invalid_value(Unexpected::Str(s), &err_s.as_str())
+                Url::parse(s).map_err(|_| {
+                    Error::invalid_value(Unexpected::Str(s), &self)
                 })
             }
         }