Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MaybeUninit for storage of inline items #162

Merged
merged 2 commits into from Oct 19, 2019
Merged

Use MaybeUninit for storage of inline items #162

merged 2 commits into from Oct 19, 2019

Commits on Oct 18, 2019

  1. Use MaybeUninit for storage of inline items. 

    This includes two breaking changes, in addition to the fact that it will
require a MSRV bump:

1. The functions on the `Array` trait `ptr` and `ptr_mut` have been
   removed. Because these took a `&self`/`&mut self` argument, there's
   no way for us to call them when we only have a `MaybeUninit<A>`. Now,
   we just use the memory of the object directly.

   This limits the flexibility of custom implementations of `Array`,
   (they can no longer return pointers to values other than themselves)
   but I imagine this is very rare and was probably broken somehow to
   begin with. Anybody who does this will get a compile error.

2. `from_buf_and_len_unchecked` now takes a MaybeUninit<A>, so that
   callers have the option of only partially initializing the array.
    Thom Chiovoloni committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    a83ccec View commit details
    Browse the repository at this point in the history

  2. Run miri in CI, and bump MSRV

    Thom Chiovoloni committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    28c09eb View commit details
    Browse the repository at this point in the history