Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched Bindgen to Use BINDGEN_CXXFLAGS Environment Variable #437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switched Bindgen to Use BINDGEN_CXXFLAGS Environment Variable #437

wants to merge 1 commit into from

Conversation

Redfire75369
Copy link
Contributor

Resolves #435, using the second approach mentioned.
Will require a change in servo at the following location to env["CXXFLAGS"] = env["BINDGEN_CXXFLAGS"] = ' '.join([.
https://github.com/servo/servo/blob/bbc35b682f0fb926364e5800d20f77bba944a020/python/servo/command_base.py#L690

@sagudev
Copy link
Member

sagudev commented Dec 6, 2023

There is BINDGEN_EXTRA_CLANG_ARGS, could we use it instead of introducing new variable?

@Redfire75369
Copy link
Contributor Author

The issue is CXXFLAGS being passed to both bindgen and cc/makefile.cargo, not bindgen itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Builds Fail when clang-cl Flags are added to CXXFLAGS
2 participants
@Redfire75369 @sagudev