Use std matches macro
#440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom `matches` macro was added before the standard library version was added. The standard library `matches` macro was added in Rust 1.42 [1]. The implementations are slightly different but the documentation is very similar. Additionally, some of the `_tt_as_expr_hack` were no longer used with this change. [1] https://doc.rust-lang.org/std/macro.matches.html
|
The build failed because it was building with Rust 1.36.0. Is there a reason that Rust 1.36.0 is required? It is from July 4th 2019. UPDATE1: I've asked in the Zullip chat too https://servo.zulipchat.com/#narrow/stream/263398-general/topic/Rust.201.2E36.2E0.20requirement |
Merged
|
☔ The latest upstream changes (presumably #466) made this pull request unmergeable. Please resolve the merge conflicts. |
|
We're moving to 1.49.0 in #469, so this can merge after that one. |
|
@bors-servo r+ |
|
📌 Commit 0510f52 has been approved by |
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom
matchesmacro was added before the standard library version wasadded. The standard library
matchesmacro was added in Rust 1.42 [1]. Theimplementations are slightly different but the documentation is very similar.
Additionally, some of the
_tt_as_expr_hackuses were no longer used with thischange.
[1] https://doc.rust-lang.org/std/macro.matches.html