use trace!() in tokenizer, to reduce log spam #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
html5ever doesn't currently use trace!() anywhere. This patch downgrades a few of the noisiest debug!() calls to use trace!() instead. This seems like a more reasonable log level for a tokenizer. This makes configuring env_logger to debug other code easier (RUST_LOG=debug rather than RUST_LOG=html5ever=info,debug), and makes working with minimal wasm log frameworks like console_log nicer (the console_log crate doesn't have a way to set different levels for different log prefixes).
jdm
approved these changes
Feb 16, 2022
|
@bors-servo r+ |
|
📌 Commit 3cf2fb1 has been approved by |
|
☀️ Test successful - checks-github |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html5ever doesn't currently use trace!() anywhere. This patch
downgrades a few of the noisiest debug!() calls to use trace!()
instead.
This seems like a more reasonable log level for a tokenizer.
This makes configuring env_logger to debug other code easier
(RUST_LOG=debug rather than RUST_LOG=html5ever=info,debug), and
makes working with minimal wasm log frameworks like console_log
nicer (the console_log crate doesn't have a way to set different
levels for different log prefixes).
There is a single debug statement in html5ever/src/tokenizer/mod.rs that I've not changed:
I didn't change this to trace, because I notice this log line anywhere in my logs. If you want me to change this too, then I can.
I'm also happy to close this PR, if you think it's not appropriate.