Skip to content

Config Schema: Improve error message and documentation #9639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 24, 2021

Improve communication of configuration schema errors.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
medikoo Mariusz Nowak
@medikoo medikoo self-assigned this Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #9639 (c979b2d) into master (38e463a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9639   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files         321      321           
  Lines       12159    12160    +1     
=======================================
+ Hits        10476    10477    +1     
  Misses       1683     1683           
Impacted Files Coverage Δ
lib/classes/ConfigSchemaHandler/index.js 90.12% <100.00%> (-0.07%) ⬇️
lib/utils/eventuallyUpdate.js 27.35% <0.00%> (+0.69%) ⬆️
lib/plugins/standalone.js 46.51% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e463a...c979b2d. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik June 24, 2021 14:46
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call 👍

@medikoo medikoo merged commit a36247b into master Jun 24, 2021
@medikoo medikoo deleted the 0624-improve-config-error-reporting branch June 24, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants