Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of pre-releases in frameworkVersion validation #8166

Merged
merged 2 commits into from Sep 2, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 2, 2020

Some of our tests (https://github.com/serverless/serverless/pull/8163/checks?check_run_id=1057358350) in v2 pre-release branch got broken when frameworkVersion was unconditionally added to serverless configurations.

It's due to pre-releases not being matched by * version range (reason unknown -> npm/node-semver#329)

This patch ensures, that * matches pre-releases as well.

Additionally provided workaround for EFS integration test CI fail: https://github.com/serverless/serverless/runs/1056731807

@medikoo medikoo added the bug label Sep 2, 2020
@medikoo medikoo self-assigned this Sep 2, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #8166 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8166   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files         248      248           
  Lines        9424     9424           
=======================================
  Hits         8316     8316           
  Misses       1108     1108           
Impacted Files Coverage Δ
lib/classes/Service.js 88.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aad819...c972368. Read the comment docs.

@medikoo medikoo merged commit ee2355e into master Sep 2, 2020
@medikoo medikoo deleted the 0902-fix-version-validation branch September 2, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants