Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint and style patches #7004

Merged
merged 2 commits into from Nov 26, 2019
Merged

Lint and style patches #7004

merged 2 commits into from Nov 26, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 25, 2019 •
edited

Purely style updates:

  • ESlint with v6.7.0 got a bug fix to operator-assignmentrule, on which we rely on, and that exposed few lint issues on our side -> https://travis-ci.org/serverless/serverless/jobs/616586600. Fixed here
  • Prettier with v1.19 introduced minor changes to formatting, which affected few files. Updated those files to reflect new formatting. It's to help users avoid unrelated changes in their PR's (some prettify whole project)

@medikoo medikoo added this to the 1.59.0 milestone Nov 25, 2019
@medikoo medikoo self-assigned this Nov 25, 2019
eahefnawy
eahefnawy approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@eahefnawy eahefnawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M 👍

@medikoo medikoo merged commit c9d56d1 into master Nov 26, 2019
@medikoo medikoo deleted the lint-and-style-improvements branch November 26, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eahefnawy eahefnawy eahefnawy approved these changes

@astuyve astuyve Awaiting requested review from astuyve

Assignees

@medikoo medikoo

Labels
cat/dx
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@medikoo @eahefnawy @pmuens