Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Upgrade dependencies, improve isolation and experience on Windows #6208

Merged
merged 63 commits into from Jun 5, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 3, 2019

Closes #6116

  • Upgrade:
    • chai from v3 to v4
    • chai-as-promised from v6 to v7
    • mock-require from v1 to v3
    • proxyquire from v1 to v2
  • Fix exposed issues
  • Improve home dir isolation among test runs
  • Improve logic responsible for local invocations, so spawn errors are handled (they were thrown in the air as uncaught exceptions), and promise rejects with them instead of EPIPE errors (which are no longer introduced in such case)
  • Ensure isolated tests run without issues on Windows
  • Increase default timeout to 5000 (with 2000 on Windows VM some tests occassionally fail with timeout errors)
  • Introduce skip with notice functionality. It allows us to skip test destined to fail due to our environment setup (e.g. lack of admin rights, Python not installed etc.). It's configured to be ineffective in CI, where all tests are expected to pass.
  • Patch other discovered Mocha bugs

Is this ready for review?: YES
Is it a breaking change?: NO

@medikoo medikoo added this to the 1.45.0 milestone Jun 3, 2019
@medikoo medikoo self-assigned this Jun 3, 2019
@medikoo medikoo marked this pull request as ready for review June 3, 2019 15:47
@medikoo medikoo changed the title Tests: Upgrade Chai Tests: Upgrade dependencies, improve isolation and experience on Windows Jun 5, 2019
@medikoo medikoo requested a review from pmuens June 5, 2019 10:03
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Really nice cleanup 👍

LGTM :shipit:

@medikoo medikoo merged commit 3b77632 into master Jun 5, 2019
@pmuens pmuens deleted the upgrade-chai branch June 5, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky unit tests
2 participants