Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxImageCount config to control ECR lifecycle policy #12280

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

mars-lan
Copy link
Contributor

Closes: #12279

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4dfebd) 86.65% compared to head (11b05b3) 86.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12280   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files         311      311           
  Lines       13089    13093    +4     
=======================================
+ Hits        11342    11346    +4     
  Misses       1747     1747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mars-lan
Copy link
Contributor Author

mars-lan commented Dec 1, 2023

@Mmarzex PTAL, thanks.

@mars-lan
Copy link
Contributor Author

mars-lan commented Dec 5, 2023

Ping @medikoo. Would really appreciate a review. Thanks.

@medikoo
Copy link
Contributor

medikoo commented Dec 6, 2023

@mars-lan thanks for your contribution, still I'm no longer at Serverless Inc. and I don't have necessary rights to accept and merge any work. I believe it's @Mmarzex and @ac360 which are handling contributions right now.

@mars-lan
Copy link
Contributor Author

@Mmarzex & @ac360 could you please review & merge this?

@s27y
Copy link

s27y commented Feb 1, 2024

Hi @Mmarzex @ac360
Can you review this PR?

@IkKan
Copy link

IkKan commented Feb 6, 2024

Hi @Mmarzex @ac360
Can you please review this PR?

Thank you!

@martinezpl
Copy link

Hi @Mmarzex @ac360
Can you please review this PR?

Thank you!

@LorenzoRogai
Copy link

Hi,

Do you have any news on this PR? This is essential

Thank you

@vrctin
Copy link

vrctin commented May 4, 2024

@Mmarzex @ac360

Any news on this PR?

@joboyx
Copy link

joboyx commented May 16, 2024

Hi @Mmarzex @ac360

just bumping this PR since this is a good addition, and we need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure ECR Lifecycle Policy
9 participants