Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support file source esm modules #12198

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

perrin4869
Copy link
Contributor

@perrin4869 perrin4869 commented Oct 4, 2023

Closes: #12197

@perrin4869 perrin4869 force-pushed the feat/file-source-esm branch 2 times, most recently from 912e8da to 079171f Compare October 4, 2023 17:49
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ad8bbf1) 86.65% compared to head (f7b3066) 86.65%.
Report is 1 commits behind head on main.

❗ Current head f7b3066 differs from pull request most recent head ef2597c. Consider uploading reports for the commit ef2597c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12198      +/-   ##
==========================================
- Coverage   86.65%   86.65%   -0.01%     
==========================================
  Files         311      311              
  Lines       13089    13095       +6     
==========================================
+ Hits        11342    11347       +5     
- Misses       1747     1748       +1     
Files Coverage Δ
lib/configuration/variables/sources/file.js 97.40% <85.71%> (-1.19%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support variable source file type using esm modules
1 participant