Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove inline-comment from .editorconfig #12186

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

icholy
Copy link
Contributor

@icholy icholy commented Sep 26, 2023

The EditorConfig spec does not allow inline comments since v0.15.0.

See: https://spec.editorconfig.org/#no-inline-comments

@icholy
Copy link
Contributor Author

icholy commented Sep 26, 2023

Relevant neovim/neovim#25372

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ad8bbf1) 86.65% compared to head (bfb7dbe) 86.65%.
Report is 1 commits behind head on main.

❗ Current head bfb7dbe differs from pull request most recent head 3d53814. Consider uploading reports for the commit 3d53814 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12186   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files         311      311           
  Lines       13089    13089           
=======================================
  Hits        11342    11342           
  Misses       1747     1747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant