Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Minor updates for Dashboard V.2 #12170

Merged
merged 4 commits into from
Sep 20, 2023
Merged

docs: Minor updates for Dashboard V.2 #12170

merged 4 commits into from
Sep 20, 2023

Conversation

skierkowski
Copy link
Member

Minor updates to the Dashboard V.2 docs to reflect feedback and additional post-launch review.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: +0.10% 🎉

Comparison is base (c66aad7) 86.54% compared to head (9a19766) 86.65%.
Report is 9 commits behind head on main.

❗ Current head 9a19766 differs from pull request most recent head 2876d80. Consider uploading reports for the commit 2876d80 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12170      +/-   ##
==========================================
+ Coverage   86.54%   86.65%   +0.10%     
==========================================
  Files         311      311              
  Lines       13122    13089      -33     
==========================================
- Hits        11357    11342      -15     
+ Misses       1765     1747      -18     
Files Changed Coverage Δ
.../cli/commands-schema/common-options/aws-service.js 100.00% <ø> (ø)
lib/cli/commands-schema/no-service.js 100.00% <ø> (ø)
lib/cli/handle-error.js 89.13% <ø> (ø)
lib/cli/interactive-setup/deploy.js 94.28% <ø> (ø)
lib/cli/interactive-setup/utils.js 85.45% <ø> (ø)
lib/cli/render-help/general.js 72.22% <ø> (ø)
commands/logout.js 80.00% <50.00%> (+1.42%) ⬆️
bin/serverless.js 48.00% <100.00%> (ø)
lib/cli/interactive-setup/aws-credentials.js 83.16% <100.00%> (ø)
lib/cli/interactive-setup/dashboard-login.js 80.85% <100.00%> (-1.15%) ⬇️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skierkowski skierkowski merged commit c5b6e41 into main Sep 20, 2023
5 checks passed
@skierkowski skierkowski deleted the SC-1552 branch September 20, 2023 14:40
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
* docs: Remove reference to deprecated features

* docs: Add header to Node.js section

* docs: Clarifying provider types in Dashboard v.2

* docs: Adding clarifying on log collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants