-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nodejs18 in custom-resources #12146
Conversation
@svoychik Thanks for looking at this. However we can't just increment the runtime version. These custom resource handlers use |
Thanks for the response. I can take a look on the adjustments required for aws-sdk3, and the changes in this PR If you don’t mind |
Go for it @svoychik 👍 |
@Mmarzex I went through the repo to find the code that is used by those custom lambda functions. Please, take a look at my code and whether my changes make sense. |
@Mmarzex Hi, Could you give me some feedback on this, please? |
Hey guys, is there any ETA when this will be merged? |
Can someone please action this ASAP. Node16 is now end of life |
can you please resolve the conflicts ? 😄 |
Any updates, guys ? |
Just got notices from AWS on end-of-support for node 16 runtime - end of standard support is 11 Mar 2024 (deprecated support ending 11 Apr 2024). I'd suggest move fixed value to nodejs 20.x (now latest runtime) (or use the runtime from the provider->runtime setting) EDIT: notice has different date than the lambda runtime page, but still coming relatlively soon - and node16 has been out of support since September 2023. "As described in the Lambda runtime support policy [2], end of support for language runtimes in Lambda happens in several stages. Starting on June 12, 2024, Lambda will no longer apply security patches and other updates to the Node.js 16 runtime used by Lambda functions, and functions using Node.js 16 will no longer be eligible for technical support. Also, Node.js 16 will no longer be available in the Console, although you can still create and update functions using Node.js 16 via AWS CloudFormation, the AWS CLI, AWS SAM, or other tools. Starting July 15, 2024, you will no longer be able to create new Lambda functions using the Node.js 16 runtime. Starting August 15, 2024, you will no longer be able to update existing functions using the Node.js 16 runtime." |
Please resolve this ASAP. node 16.x AWS end-of-support for node 16 runtime is very near. |
Since there hasn't been any activity from the serverless team on this issue, I suggest removing the custom serverless lambda. Here's a guide for eliminating the api-gw lambda, shortly speaking you have 2 options:
Guidance on the second option: In your serverless.yml, set 'roleManagedExternally' to true, like this:
From now on, you will need to manage those permissions yourself. However, keep in mind that the permissions granted by the custom lambda earlier will not disappear. This means that the API Gateway will continue to send logs until you clean up the AWS environment. To explicitly grant these permissions, you can implement a custom script using CloudFormation, Terraform, or AWS CDK. |
The lambda is also used for S3 and for Cognito User Pool - anyone work out a similar workaround to avoid them as @svoychik nicely outlined for API GW? |
Good to read here, any updates for this issue? @Mmarzex |
any update on this? we need this ASAP since Node.js 16 support in Lambda will end on June 12, 2024 |
Hi everyone, this is now available in the v4.0 alpha |
@Mmarzex will this be available in 3.x? |
As of now, we cannot migrate to sls v4 (which is still in alpha!) until Jul 15, 2024. Probably others also have to see if they get "approval" for the sls v4 licensing changes or not, evaluate alternatives, adapt their code to v4 and test it, and so on. Not merging this to v3 would shorten the deadline for all those decisions drastically, from "end of 2024" to "mid of July", and would force people to upgrade earlier than they actually can or should. Please let us know what you plan to do with this PR - thanks! |
Same issue here |
Are there any updates on this PR @Mmarzex @medikoo @eahefnawy ? we are 2 months away from the deadline on Aws. since v4 is still in alpha it would be useful to have it on v3 thank you guys for all! |
@sergioissi thanks for asking. I'm personally no longer with Serverless Inc. and I don't have the necessary rights to approve and push any work here. I believe @eahefnawy @ac360 and @Mmarzex are the right contacts for that |
FYSA- #12133 (comment) (local plugins style work-around, EDIT: to at-least get rid of notice for existing stacks-) |
(Don't get me wrong - this is not a reason not to include this PR into v3! There won't be any Node.js security patches for example. Just wanted to let you know about the update.) |
we're still waiting for this |
Are there any plans to merge this PR? @Mmarzex |
+1 |
Because @svoychik is not available to resolve conflicts so I have recreated a new PR, pls review and merge it #12445 @Mmarzex @eahefnawy @ac360 |
Can we get an update on this? |
Any updates, guys @eahefnawy @ac360 and @Mmarzex? |
Are we able to merge it now? 6/12 is only 2 weeks away. |
Hey serverless guys (@eahefnawy @Mmarzex), is there any update on this? It seems that Serverless wants to push its users to v4 (which is still an alpha AFAIU) to earn money, which is fine. Actually, we will be considering dropping Serverless since such behavior is simply irresponsible. |
They responded in a related issue:
|
Great to hear that, thank you! |
Hi everyone, thank you for your patience, this is now supported in a new v3 release, specifically v3.39.0, it is available on NPM now. |
Closes: #12133
similar to #11359
As NodeJS 16 security support recently ended all internal lambda functions have to be migrated to the latest LTS nodejs18
I made changes in the same way they were done in https://github.com/serverless/serverless/pull/11367/files