Add support for Fn::Base64 and allow it to be used in env vars #11671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mt-ronkorving
changed the title
1 task
medikoo
reviewed
Jan 12, 2023
mt-ronkorving
force-pushed
the
base64-function-support-in-env-vars
branch
from
96dcc39
to
848eb6a
Compare
medikoo
reviewed
Jan 16, 2023
There was a problem hiding this comment.
@mt-ronkorving thanks for update.
Please see my comments, and once update is ready be sure to re-request review in reviewers box. Thank you!
mt-ronkorving
force-pushed
the
base64-function-support-in-env-vars
branch
from
848eb6a
to
5a2ffd2
Compare
medikoo
approved these changes
Jan 18, 2023
|
Thanks for merging! Looking forward to the release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11670
This is heavily based on #11461 and I would encourage the people involved in that PR (@jurriaanpro and @medikoo) to have a look please 🙏 Thank you!