New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add UAE Spain and Zurich to the AWS regions #11524
Conversation
Codecov ReportBase: 85.63% // Head: 85.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #11524 +/- ##
=======================================
Coverage 85.63% 85.63%
=======================================
Files 314 314
Lines 13133 13133
=======================================
Hits 11246 11246
Misses 1887 1887
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Although pushing changes like this make me feel like an opensource contributor again 😂 , it would be great to automate this 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @umutuzgur !
How do you think, it can be automated?
I was thinking about a github actions cron job that runs everyday, parses an endpoints where the DCs are located from AWS which I assume they have something for this, compares it with the ones in this file and creates a new PR if it detects a drift |
@umutuzgur do you think creating such PR and involved maintenance work of auto-update logic is worth it in comparison to manual update of the list we practise currently? |
@medikoo Maybe not. I don't really know how often people create issues regarding the unsupported regions. I would say it is not worth it since AWS has 2-3 new DCs every year but it might be just nice to get rid of a recurring situation once and for all and not think about it again. |
@umutuzgur if you're into, you may prepare a PR that will automate that, but I assume it's complexity will be big, and I would be reluctant to take it assuming. we have to do such update as today maybe once a year. It seems that less cost and friction is when this is handled manually |
Closes: #11522