fix(AWS CloudFront): Correctly recognise ResponseHeadersPolicyId property #11398
Conversation
Codecov ReportBase: 85.85% // Head: 85.85% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #11398 +/- ##
=======================================
Coverage 85.85% 85.85%
=======================================
Files 314 314
Lines 13253 13253
=======================================
Hits 11378 11378
Misses 1875 1875
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -128,6 +128,7 @@ class AwsCompileCloudFrontEvents { | |||
| FieldLevelEncryptionId: { type: 'string' }, | |||
| OriginRequestPolicyId: { type: 'string' }, | |||
| SmoothStreaming: { type: 'boolean' }, | |||
| ResponseHeadersPolicyId: { type: 'string' }, | |||
There was a problem hiding this comment.
Hey @benheymink 👋 I think it would be awesome to add a test that confirms this property is recognized without issues
There was a problem hiding this comment.
@pgrzesik I don't see any sort of tests currently evaluating these properties, but I confess I'm not super familiar with the code base. Could you point me to the existing tests for the other properties so that I can extend them?
There was a problem hiding this comment.
@pgrzesik Yeah still no luck on those tests, and I don't really want to perform major heart surgery to your test structure....
|
Closing as addressed with #11633 |
Closes: #11397