New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to give EventBridge events custom names #11690
Conversation
Codecov ReportBase: 86.56% // Head: 86.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11690 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 313 313
Lines 13102 13104 +2
=======================================
+ Hits 11342 11344 +2
Misses 1760 1760
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ROSeaboyer. All looks good, just tests need to be reconfigured.
test/unit/lib/plugins/aws/package/compile/events/event-bridge/index.test.js
Outdated
Show resolved
Hide resolved
test/unit/lib/plugins/aws/package/compile/events/event-bridge/index.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ROSeaboyer !
Closes: #11360