Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to give EventBridge events custom names #11690

Merged
merged 7 commits into from Jan 19, 2023
Merged

Add ability to give EventBridge events custom names #11690

merged 7 commits into from Jan 19, 2023

Conversation

ROSeaboyer
Copy link
Contributor

Closes: #11360

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 86.56% // Head: 86.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (35354fd) compared to base (f020bd8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11690   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         313      313           
  Lines       13102    13104    +2     
=======================================
+ Hits        11342    11344    +2     
  Misses       1760     1760           
Impacted Files Coverage Δ
...s/aws/package/compile/events/event-bridge/index.js 97.65% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ROSeaboyer. All looks good, just tests need to be reconfigured.

@ROSeaboyer ROSeaboyer removed their assignment Jan 19, 2023
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ROSeaboyer !

@medikoo medikoo merged commit b925c4c into serverless:main Jan 19, 2023
@ROSeaboyer ROSeaboyer deleted the eventbridge-custom-names branch February 2, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for naming EventBridge resources
2 participants