Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for naming EventBridge resources #11360

Closed
1 task done
ROSeaboyer opened this issue Aug 28, 2022 · 3 comments · Fixed by #11690
Closed
1 task done

Add support for naming EventBridge resources #11360

ROSeaboyer opened this issue Aug 28, 2022 · 3 comments · Fixed by #11690

Comments

@ROSeaboyer
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Use case description

In environments where a naming scheme is strictly defined, there needs to be the potential to specify a custom name so that it properly fits in the naming scheme.

Proposed solution (optional)

Support for a name property is added (same property as what's used for other function events) and, where the RuleName variable is defined in lib/plugins/aws/package/compile/events/event-bridge/index.js, the first option used is the custom name passed in, and in cases where that isn't present, the fallback is the existing logic that's been added.

I have draft changes locally to add this feature in, but wanted some sign-off to ensure that there wasn't a parallel effort for this sort of feature elsewhere

@ROSeaboyer
Copy link
Contributor Author

Bumping this issue up; any thoughts on this either way?

@medikoo
Copy link
Contributor

medikoo commented Jan 18, 2023

@ROSeaboyer sorry for not looking into it earlier. This proposal looks good to me. Can you reopen the PR and ensure it's up to date with main branch?

@ROSeaboyer
Copy link
Contributor Author

@medikoo No worries; reopened as #11690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants