Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWS CloudFront): Add ResponseHeadersPolicyId to behavior schema #11633

Merged

Conversation

jasonrowsell
Copy link
Contributor

@jasonrowsell jasonrowsell commented Dec 25, 2022

Closes: #11397

@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Base: 85.86% // Head: 86.03% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (5f914ca) compared to base (007af46).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11633      +/-   ##
==========================================
+ Coverage   85.86%   86.03%   +0.17%     
==========================================
  Files         315      314       -1     
  Lines       13191    13164      -27     
==========================================
  Hits        11326    11326              
+ Misses       1865     1838      -27     
Impacted Files Coverage Δ
.../plugins/aws/package/compile/events/cloud-front.js 97.72% <ø> (ø)
scripts/pkg/upload/index.js 0.00% <0.00%> (ø)
scripts/pkg/upload/china.js

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@medikoo medikoo merged commit 906ea31 into serverless:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serverless incorrectly warns that ResponseHeadersPolicyId as a CloudFront behaviour property is invalid
2 participants