Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stage under apiGateway to override default. #11487

Merged
merged 1 commit into from Oct 31, 2022

Conversation

pavanandhukuri
Copy link
Contributor

Adds new property under apiGateway to override default

Addresses: #8346

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 85.79% // Head: 85.79% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d554c87) compared to base (d1d9494).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11487   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files         314      314           
  Lines       13259    13261    +2     
=======================================
+ Hits        11375    11377    +2     
  Misses       1884     1884           
Impacted Files Coverage Δ
...ompile/events/api-gateway/lib/hack/update-stage.js 95.06% <100.00%> (ø)
lib/plugins/aws/provider.js 94.70% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pavanandhukuri! That looks very good

@medikoo medikoo merged commit 0a49c4f into serverless:main Oct 31, 2022
@jattkaim
Copy link

@pavanandhukuri This is currently not functional, was this ever functional? see that the tests are passing and the code itself seems quite simple. Unsure why this is currently not functional.

@medikoo
Copy link
Contributor

medikoo commented Jan 13, 2023

@jattkaim @pavanandhukuri as I check, this PR covered support for it in updates that Framework does after CF deployment finalizes, the updates made directly with AWS SDK.

What was omitted is the resolution of the custom stage name for deployment resource in CF template. So technically, this never worked correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants