Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS API Gateway: Allow stage customization #8346

Closed
nl-brett-stime opened this issue Oct 5, 2020 · 6 comments
Closed

AWS API Gateway: Allow stage customization #8346

nl-brett-stime opened this issue Oct 5, 2020 · 6 comments

Comments

@nl-brett-stime
Copy link

Use case description

API Gateway has a feature to manage different stages (dev/qa/prod). However, some users have their stages split across different AWS accounts. Other users may manage stages via IaC tools such as Cloud Formation, Terraform and Serverless. In these cases, API Gateway's stage feature becomes redundant: https://stackoverflow.com/a/53652722/93345

Proposed solution

Allow the stage value sent to API Gateway to differ from Serverless' stage but fall back to Serverless' stage as a default value.

E.g.,

  provider:
  name: aws
  stage: ${opt:stage, 'dev'}
  apiGateway:
    stage: aValueThatDiffersFromTheOneAbove
@medikoo
Copy link
Contributor

medikoo commented Oct 6, 2020

@nl-brett-stime sounds reasonable to me

@medikoo medikoo changed the title Allow using a different stage for API Gateway than the Serverless stage option AWS API Gateway: Allow stage customization Nov 30, 2020
@pavanandhukuri
Copy link
Contributor

@medikoo I would like to pick this up if it is already not done. Can you assign it to me?

@medikoo
Copy link
Contributor

medikoo commented Oct 25, 2022

@pavanandhukuri sure. PR's welcome!

@pavanandhukuri
Copy link
Contributor

Raised a PR #11487

@pavanandhukuri
Copy link
Contributor

@medikoo I missed tagging the PR with Closes comment.. I think we will have to close this issue manually now...

@medikoo
Copy link
Contributor

medikoo commented Nov 2, 2022

@pavanandhukuri indeed, thanks for reminder!

@medikoo medikoo closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants