fix: checks on kafka startingpositiontimestamp param

serverless · Nov 3, 2022 · f7ecb9f · f7ecb9f
1 parent fe3b9e6
commit f7ecb9f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/plugins/aws/package/compile/events/kafka.js b/lib/plugins/aws/package/compile/events/kafka.js
@@ -154,7 +154,10 @@ class AwsCompileKafkaEvents {
         const startingPosition = event.kafka.startingPosition || 'TRIM_HORIZON';
         const startingPositionTimestamp = event.kafka.startingPositionTimestamp;
 
-        if (startingPosition === 'AT_TIMESTAMP' && !startingPositionTimestamp) {
+        if (
+          startingPosition === 'AT_TIMESTAMP' &&
+          !(startingPositionTimestamp !== undefined && startingPositionTimestamp !== null)
+        ) {
           throw new ServerlessError(
             `You must specify startingPositionTimestamp for function: ${functionName} when startingPosition is AT_TIMESTAMP.`,
             'FUNCTION_KAFKA_STARTING_POSITION_TIMESTAMP_INVALID'
@@ -254,7 +257,7 @@ class AwsCompileKafkaEvents {
           };
         }
 
-        if (startingPositionTimestamp !== undefined) {
+        if (startingPositionTimestamp !== undefined && startingPositionTimestamp !== null) {
           kafkaResource.Properties.StartingPositionTimestamp = startingPositionTimestamp;
         }