Force noEmit compiler option to be false #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a developer makes a mistake and has noEmit with a value of true in their tsconfig.json, this plugin errors out with "Typescript compilation failed" message. The message is wrong, as compilation actually did succeed. The real problem is that there simply were no files written to disk and as such there are no files for serverless to deploy. To prevent developers from making this mistake, its value can be forced by the plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a developer makes a mistake and has noEmit with a value of true in their tsconfig.json, this plugin errors out with "Typescript compilation failed" message.
The message is wrong, as compilation actually did succeed. The real problem is that there simply were no files written to disk and as such there are no files for serverless to deploy.
To prevent developers from making this mistake, its value can be forced by the plugin.