Support V3 log interface #284
Conversation
There was a problem hiding this comment.
Thanks a lot @colemanja91 🙇 It looks good so far - do you plan any additional changes to it?
|
@pgrzesik I kept it in WIP while doing some local testing with v3 - seems ready for a review! |
|
Thanks @colemanja91 👍 I'll run it locally to see if there's anything missing in the workflow. 👍 |
|
Hello @colemanja91 - how did you verify it's properly working on local? I'm working with your branch locally and it doesn't seem to take the effect. Looking at the code it seems like the original setup of |
There was a problem hiding this comment.
Thanks @colemanja91, looks good in general, but I'm afraid the setup is a bit wrong - please let me know what do you think
| this.serverless = serverless; | ||
| this.options = options; | ||
|
|
||
| if (v3Utils) { |
There was a problem hiding this comment.
This is setup on GoogleIndex level where everywhere in the code you reference it from this.provider - I believe it's not reachable on GoogleProvider level.
| @@ -22,7 +22,11 @@ module.exports = { | |||
|
|
|||
| let vpcEgress = funcObject.vpcEgress || this.serverless.service.provider.vpcEgress; | |||
|
|
|||
| this.serverless.cli.log(`Compiling function "${functionName}"...`); | |||
| if (this.log) { | |||
| this.log.notice(`Compiling function "${functionName}"...`); | |||
There was a problem hiding this comment.
This looks like a candidate for progress as it can take some time
Add support for Serverless V3 logging (per #279 )