Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to individually package functions #164

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wootencl
Copy link

Quick pass at adding individual packaging functionality. Mostly looked at the AWS implementation and tried to create parity between here and there.

@pmuens Happy to add tests + get linting, etc. in order if this is something you'd be willing to merge. Mostly don't want to sink any more time into this if that's not the case.

Fixes: #89

@simonasdev
Copy link

simonasdev commented May 15, 2019

would love to see this merged :D

@saiaman
Copy link

saiaman commented Jun 14, 2019

any news ?

@saiaman
Copy link

saiaman commented Jun 14, 2019

Quick pass at adding individual packaging functionality. Mostly looked at the AWS implementation and tried to create parity between here and there.

@pmuens Happy to add tests + get linting, etc. in order if this is something you'd be willing to merge. Mostly don't want to sink any more time into this if that's not the case.

Fixes: #89

Can you please patch eslint problems in order to get travis working ?

@wootencl
Copy link
Author

@saiaman Feel free to fork my fork and create another PR with the eslint problems resolved if desired. At current I'm unfortunately a bit strapped for time and don't want to invest any more into this particularly with the relative inactivity of this repo.

@markmssd
Copy link

@wootencl perhaps assigning other maintainers to the repo would help? I'm willing to give a hand, I'm sure other people would do.

@markmssd
Copy link

markmssd commented Jul 14, 2019

@wootencl I've tested your changes, it deploys functions properly 👍

Couple of points I noticed:

  • It doesn't work anymore without the individually option
  • All the functions upload with the same .zip size. Is that normal? I suppose it is right?
  • *EDIT: A lot of unit tests are failing

Let's join forces to fix them!

@wootencl
Copy link
Author

@markmssd I'll admit, my availability is opening up a bit so could possibly lend a hand in maintaining this repo. Ultimately though, that decision is up to @pmuens.

@sushilkg
Copy link

Bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual packaging of function does not work for Google Cloud Functions
5 participants