Updated Dependencies. Fixed eslint errors. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
pmuens
reviewed
Aug 29, 2019
There was a problem hiding this comment.
Hey @sulaysumaria thanks a ton for taking the time to work on this 💯 👍
I know it's been a while. We just merged #176 which fixes the vulnerability part. Unfortunately this merge introduced some conflicts. Do you think you can rebase this PR so that we can get the Prettier changes in place?
Furthermore we've created https://github.com/serverless/eslint-config to re-use the same config for all of our projects? Do you think you can incorporate that?
Thanks again for working on this and let us know if you need any help 👍
|
Sure @pmuens , I will take a look this weekend. |
Awesome! Thanks a lot @sulaysumaria 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #103
Resolves #108
Resolves #87
All tests pass after updating packages.
npm auditreturned 0 vulnerabilities.