Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serviceAccount option for deployment #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xyi
Copy link
Contributor

@xyi xyi commented Mar 13, 2019

No description provided.

@vranystepan
Copy link

Cool! I hope it'll be merged soon 👍

@davidjb99
Copy link

This is exactly what I wanted, would be great to get it merged!

@paulotokimatu
Copy link

Related to #161

@pmuens Do you think this good to go?

@jorgejch
Copy link

Anxious to see this in.

@jorgejch
Copy link

btw, tested. works.

functions:
  first:
    serviceAccount: account_email
    ...

@luisgreen
Copy link
Contributor

Do we have an ETA for merge?? I'm really wanting this feature :)

@jamestjw
Copy link

jamestjw commented Mar 1, 2020

This feature is super desirable, really need this.

@shaharappload
Copy link

This pull request doesn't work anymore, becuase it's now called serviceAccountEmail in GCP Cloud Functions JSON/YAML payload.

You can use serverless-google-cloudfunctions-amazing npm package based on serverless-google-cloudfunctions-awsome with some advanced features that are not supported yet in serverless-google-cloudfunctions package.

Usage example (using variable reference):

functions:
  example:
    serviceAccount: ${self:custom.serviceAccount.${self:provider.stage}}

OR

functions:
  example:
    serviceAccount: serviceAccountEmail@my-project.iam.gserviceaccount.com

@GerardPaligot
Copy link

After one year, there is always interested people about this feature in the SF GCP plugin (including me).
The project of @shaharappload is interesting but that could be great to add this kind of feature natively in the plugin.
If I create a new PR for this, it will be reviewed?

@davedc
Copy link

davedc commented Apr 21, 2022

@GerardPaligot was looking to make a patch with this. Found that this was already merged here.

functions:
  a-function:
    serviceAccountEmail: your-sa@your-project.iam.gserviceaccount.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants