Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Workaround OOM NYC issue #394

Merged
merged 1 commit into from Mar 29, 2020
Merged

CI: Workaround OOM NYC issue #394

merged 1 commit into from Mar 29, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Mar 29, 2020

We started to observe OOM errors when doing coverage check on Node.js v10: https://travis-ci.com/github/serverless/enterprise-plugin/jobs/305196115

Issue is known on NYC side: istanbuljs/nyc#1263 and they have fix coming: istanbuljs/nyc#1293

I was not able to reproduce this when running on Node.js v13 and v12, hence I've updated CI to run coverage on v13 (which we also didn't test yet)

@medikoo medikoo self-assigned this Mar 29, 2020
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #394 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   54.39%   54.39%           
=======================================
  Files         105      105           
  Lines        2960     2960           
=======================================
  Hits         1610     1610           
  Misses       1350     1350           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45fc0b8...d12253a. Read the comment docs.

@medikoo medikoo merged commit 7478af9 into master Mar 29, 2020
@medikoo medikoo deleted the 0330-workaround-oom-issue branch March 29, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants