Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ability to use interactive stream with deploy and remove fun… #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shira-lev
Copy link

Hello,
Following the #173 issue, Here's a PR with the needed changes so that a serverless plugin requiring user input will be able to run in a serverless compose project.

The change is setting the streamStdout as true when invoking exec function in deploy and remove functions.

In addition I changed the no changes check in the deploy function since the output was changed in the serverless framework and the output is now -
Change set did not include any changes to be deployed.

Thank you,
Shira

@ROSeaboyer
Copy link

@shira-lev I'm not associated with serverless, but FYI, the "no changes" message that you're removing still pops up when someone isn't using changesets, so you'll probably need to alter it to check for either the changeset message you added or the existing message for a "no deploy" printout to be valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants