Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forgot to remove some Nullable>enable #1735

Merged
merged 2 commits into from Aug 26, 2022
Merged

forgot to remove some Nullable>enable #1735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82a00e4
forgot to remove some Nullable>enable
SimonCropp Aug 26, 2022
6acd5f0
missed some #nullable enable
SimonCropp Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Serilog/Core/IScalarConversionPolicy.cs
View file
Open in desktop
@@ -1,5 +1,4 @@
#nullable enable
using System.Diagnostics.CodeAnalysis;
using System.Diagnostics.CodeAnalysis;
using Serilog.Events;

namespace Serilog.Core;
Expand Down
1 change: 0 additions & 1 deletion src/Serilog/LoggerExtensions.cs
View file
Open in desktop
@@ -1,4 +1,3 @@
#nullable enable
using System;
using Serilog.Events;

Expand Down
1 change: 0 additions & 1 deletion test/Serilog.PerformanceTests/Serilog.PerformanceTests.csproj
View file
Open in desktop
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion test/Serilog.Tests/Serilog.Tests.csproj
View file
Open in desktop
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net6.0;net5.0;netcoreapp3.1;netcoreapp2.1;net452;net46;net48</TargetFrameworks>
<Nullable>enable</Nullable>
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion test/TestDummies/TestDummies.csproj
View file
Open in desktop
Expand Up @@ -6,7 +6,6 @@
<GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
Expand Down