Finish nullable. now enabled globally #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
reviewed
Aug 24, 2022
| @@ -67,7 +68,7 @@ internal LogEventProperty(EventProperty property) | |||
| /// </summary> | |||
| /// <param name="name">The name to check.</param> | |||
| /// <returns>True if the name is valid; otherwise, false.</returns> | |||
| public static bool IsValidName(string name) => !string.IsNullOrWhiteSpace(name); | |||
| public static bool IsValidName([NotNullWhen(true)] string? name) => !string.IsNullOrWhiteSpace(name); | |||
There was a problem hiding this comment.
Not sure the attribute makes sense here?
There was a problem hiding this comment.
without this we get build errors, since the compiler cant derive the nullability
Logger.cs(1369, 65): [CS8604] Possible null reference argument for parameter 'name' in 'LogEventProperty MessageTemplateProcessor.CreateProperty(string name, object? value, bool destructureObjects = false)'.
Merged
Twinki14
pushed a commit
to Twinki14/CitizenFX.Extensions.Client.Serilog
that referenced
this pull request
Dec 30, 2023
* nullable in LogEventProperty * nullable in JsonValueFormatter * nullable in EventProperty * nullable in LogContext * enable nullable for EnricherStack * remove "#nullable enable" and enable globally * Update Logger.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.