Finish nullable. now enabled globally (serilog#1729)

* nullable in LogEventProperty

* nullable in JsonValueFormatter

* nullable in EventProperty

* nullable in LogContext

* enable nullable for EnricherStack

* remove "#nullable enable" and enable globally

* Update Logger.cs

Directory.Build.props

@@ -7,6 +7,7 @@
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>../../assets/Serilog.snk</AssemblyOriginatorKeyFile>
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
   <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
     <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="all" />

src/Serilog/Capturing/DepthLimiter.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 
 using Serilog.Core;

src/Serilog/Capturing/GetablePropertyFinder.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/Serilog/Capturing/MessageTemplateProcessor.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using Serilog.Core;
 using Serilog.Core.Pipeline;
 using Serilog.Events;
@@ -38,7 +37,7 @@ public void Process(string messageTemplate, object?[]? messageTemplateParameters
             properties = _propertyBinder.ConstructProperties(parsedTemplate, messageTemplateParameters);
         }
 
-        public LogEventProperty CreateProperty(string? name, object? value, bool destructureObjects = false)
+        public LogEventProperty CreateProperty(string name, object? value, bool destructureObjects = false)
         {
             return _propertyValueConverter.CreateProperty(name, value, destructureObjects);
         }

src/Serilog/Capturing/PropertyBinder.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Debugging;
 using Serilog.Events;

src/Serilog/Capturing/PropertyValueConverter.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections;
 using System.Collections.Generic;
@@ -94,7 +93,7 @@ partial class PropertyValueConverter : ILogEventPropertyFactory, ILogEventProper
             _depthLimiter = new(maximumDestructuringDepth, this);
         }
 
-        public LogEventProperty CreateProperty(string? name, object? value, bool destructureObjects = false)
+        public LogEventProperty CreateProperty(string name, object? value, bool destructureObjects = false)
         {
             return new(name, CreatePropertyValue(value, destructureObjects));
         }

src/Serilog/Configuration/LoggerAuditSinkConfiguration.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Core;
 using Serilog.Events;

src/Serilog/Configuration/LoggerDestructuringConfiguration.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections;
 using Serilog.Core;

src/Serilog/Configuration/LoggerEnrichmentConfiguration.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/Serilog/Configuration/LoggerFilterConfiguration.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Core;
 using Serilog.Core.Filters;

src/Serilog/Configuration/LoggerMinimumLevelConfiguration.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Core;
 using Serilog.Events;

src/Serilog/Configuration/LoggerSettingsConfiguration.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using Serilog.Settings.KeyValuePairs;

src/Serilog/Configuration/LoggerSinkConfiguration.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;

src/Serilog/Context/EnricherStack.cs

@@ -25,8 +25,8 @@ namespace Serilog.Context
 {
     class EnricherStack: IEnumerable<ILogEventEnricher>
     {
-        readonly EnricherStack _under;
-        readonly ILogEventEnricher _top;
+        readonly EnricherStack? _under;
+        readonly ILogEventEnricher? _top;
 
         EnricherStack()
         {
@@ -53,39 +53,39 @@ class EnricherStack: IEnumerable<ILogEventEnricher>
 
         public EnricherStack Push(ILogEventEnricher t) => new(this, t);
 
-        public ILogEventEnricher Top => _top;
+        public ILogEventEnricher Top => _top!;
 
         internal struct Enumerator : IEnumerator<ILogEventEnricher>
         {
             readonly EnricherStack _stack;
             EnricherStack _top;
-            ILogEventEnricher _current;
+            ILogEventEnricher? _current;
 
             public Enumerator(EnricherStack stack)
             {
                 _stack = stack;
                 _top = stack;
-                _current = default;
+                _current = null;
             }
 
             public bool MoveNext()
             {
                 if (_top.IsEmpty)
                     return false;
                 _current = _top.Top;
-                _top = _top._under;
+                _top = _top._under!;
                 return true;
             }
 
             public void Reset()
             {
                 _top = _stack;
-                _current = default;
+                _current = null;
             }
 
-            public ILogEventEnricher Current => _current;
+            public ILogEventEnricher Current => _current!;
 
-            object IEnumerator.Current => _current;
+            object IEnumerator.Current => _current!;
 
             public void Dispose()
             {

src/Serilog/Context/LogContext.cs

@@ -52,12 +52,12 @@ namespace Serilog.Context
     public static class LogContext
     {
 #if ASYNCLOCAL
-        static readonly AsyncLocal<EnricherStack> Data = new();
+        static readonly AsyncLocal<EnricherStack?> Data = new();
 #elif REMOTING
         static readonly string DataSlotName = typeof(LogContext).FullName + "@" + Guid.NewGuid();
 #else // DOTNET_51
         [ThreadStatic]
-        static EnricherStack Data;
+        static EnricherStack? Data;
 #endif
 
         /// <summary>
@@ -215,15 +215,15 @@ public void Dispose()
 
 #if ASYNCLOCAL
 
-        static EnricherStack Enrichers
+        static EnricherStack? Enrichers
         {
             get => Data.Value;
             set => Data.Value = value;
         }
 
 #elif REMOTING
 
-        static EnricherStack Enrichers
+        static EnricherStack? Enrichers
         {
             get
             {
@@ -238,7 +238,10 @@ static EnricherStack Enrichers
                     oldHandle.Dispose();
                 }
 
-                CallContext.LogicalSetData(DataSlotName, new DisposableObjectHandle(value));
+                if (value != null)
+                {
+                    CallContext.LogicalSetData(DataSlotName, new DisposableObjectHandle(value));
+                }
             }
         }
 
@@ -251,7 +254,7 @@ public DisposableObjectHandle(object o)
             {
             }
 
-            public override object InitializeLifetimeService()
+            public override object? InitializeLifetimeService()
             {
                 var lease = base.InitializeLifetimeService() as ILease;
                 lease?.Register(LifeTimeSponsor);
@@ -269,7 +272,7 @@ public void Dispose()
 
 #else // DOTNET_51
 
-        static EnricherStack Enrichers
+        static EnricherStack? Enrichers
         {
             get => Data;
             set => Data = value;

src/Serilog/Context/LogContextEnricher.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using Serilog.Core;
 using Serilog.Events;
 

src/Serilog/Core/Enrichers/ConditionalEnricher.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Events;
 

src/Serilog/Core/Enrichers/EmptyEnricher.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using Serilog.Events;
 
 namespace Serilog.Core.Enrichers

src/Serilog/Core/Enrichers/FixedPropertyEnricher.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Events;
 

src/Serilog/Core/Enrichers/PropertyEnricher.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Events;
 

src/Serilog/Core/Enrichers/SafeAggregateEnricher.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/Serilog/Core/Filters/DelegateFilter.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Events;
 

src/Serilog/Core/IDestructuringPolicy.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System.Diagnostics.CodeAnalysis;
 using Serilog.Events;
 

src/Serilog/Core/ILogEventPropertyFactory.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 
 using Serilog.Events;
 

src/Serilog/Core/LevelOverrideMap.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/Serilog/Core/Logger.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
@@ -1332,6 +1331,7 @@ public void Fatal(Exception? exception, string messageTemplate, params object?[]
             [NotNullWhen(true)] out MessageTemplate? parsedTemplate,
             [NotNullWhen(true)] out IEnumerable<LogEventProperty>? boundProperties)
         {
+            // ReSharper disable once ConditionIsAlwaysTrueOrFalseAccordingToNullableAPIContract
             if (messageTemplate == null)
             {
                 parsedTemplate = null;

src/Serilog/Core/LoggingLevelSwitch.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using Serilog.Events;
 
 namespace Serilog.Core

src/Serilog/Core/Pipeline/MessageTemplateCache.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Events;
 

src/Serilog/Core/Pipeline/SilentLogger.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;

src/Serilog/Core/Sinks/AggregateSink.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/Serilog/Core/Sinks/ConditionalSink.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using System;
 using Serilog.Events;
 

src/Serilog/Core/Sinks/DisposeDelegatingSink.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using Serilog.Events;
 using System;
 

src/Serilog/Core/Sinks/DisposingSafeAggregateSink.cs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#nullable enable
 using Serilog.Debugging;
 using System;
 using System.Collections.Generic;