Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix dependency #75

Merged
merged 2 commits into from Dec 20, 2022
Merged

Conversation

g0hl1n
Copy link
Contributor

@g0hl1n g0hl1n commented Dec 18, 2022

This PR updates nix dependency to their latest version (0.25.0 => 0.26).

This update was without changes to the code.

This PR is a follow-up of #72.

MSRV

Furthermore bump the MSRV to 1.56.1 as this is required by nix v0.26.0 (see nix-rust/nix#1792). 0a74354 reduced the MSRV because of a Yocto dependency. Currently following rust versions are used in the maintained yocto project versions:

Therefore this MSRV change (1.46.0 => 1.56.1) shouldn't have any effect on YoctoProject releases.

Remove the patch version in the dependency definition to get minor fixes
automatically. This shouldn't be a problem as nix should be API stable
across patch versions.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
This is needed as nix v0.26.0 raised its MSRV to 1.56.1. For more
information please see the changelog:
	https://github.com/nix-rust/nix/blob/master/CHANGELOG.md#0260---2022-11-29

Or the corresponding PR:
	nix-rust/nix#1792

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting up your previous PR, as long as we still support kirkstone (which we do!) then I'm happy with the MSRV bump.

@jessebraham jessebraham merged commit 94c4f5c into serialport:main Dec 20, 2022
@g0hl1n g0hl1n deleted the g0hl1n_update-dep_nix branch March 21, 2023 12:19
sirhcel pushed a commit to sirhcel/serialport-rs that referenced this pull request May 10, 2023
* Upgrade nix to 0.26

Remove the patch version in the dependency definition to get minor fixes
automatically. This shouldn't be a problem as nix should be API stable
across patch versions.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>

* Raise the MSRV to 1.56.1

This is needed as nix v0.26.0 raised its MSRV to 1.56.1. For more
information please see the changelog:
	https://github.com/nix-rust/nix/blob/master/CHANGELOG.md#0260---2022-11-29

Or the corresponding PR:
	nix-rust/nix#1792

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants