Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sub-dependecy of clap to be compatible with MSRV #186

Merged
merged 1 commit into from
May 22, 2024

Conversation

sirhcel
Copy link
Contributor

@sirhcel sirhcel commented May 9, 2024

Fix building from a fresh start with our current MSRV 1.59.0. There has been an incompatible change with respect to the MSRV in os_str_bytes with the minor version update to 6.6.0.

As of 83fd7fb this fails with:

$ rm -r target Cargo.lock
$ export SERIALPORT_RS_TEST_PORT_1=DUMMY_1
$ export SERIALPORT_RS_TEST_PORT_2=DUMMY_2
cargo +1.59.0 test --features ignore-hardware-tests
error: package `os_str_bytes v6.6.1` cannot be built because it requires rustc 1.61.0 or newer, while the currently active rustc version is 1.59.0

This PR adds a direct dependency to os_str_bytes for tricking the dependency resolution into using a compatible version.

@sirhcel sirhcel requested a review from eldruin May 9, 2024 15:19
@eldruin
Copy link
Contributor

eldruin commented May 16, 2024

Hmm, sorry I did not look at this soon enough. There is a conflict now in the Cargo.toml. Could you have a look?

@sirhcel sirhcel force-pushed the pin-os-str-bytes-for-msrv-1.59.0 branch from ad0cb99 to 29d03bf Compare May 17, 2024 07:44
@sirhcel
Copy link
Contributor Author

sirhcel commented May 17, 2024

Thank you for pointing it out! This was a quick fix.

@eldruin eldruin merged commit d5c2605 into serialport:main May 22, 2024
30 checks passed
@sirhcel sirhcel mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants