Streamline integration tests and add first test for read timeouts #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the initial attempt of specifying the hardware ports to
be used for testing by:
* Requiring the configuration environment variables only to be
present when actually required by a test case
* Evaluating these environment variables at runtime, eliminating the
footgun that changing them does not trigger rebuilding the tests
* No longer requiring to set dummy configuration variables when not
running any hardware tests at all (like in CI).
The configuration environment variable prefix changes from
SERIALPORT_RS_TEST_ to SERIALPORT_TEST_ to match the crate name and not
the repository name.
The changes add two new dev dependencies which both look worth it:
* The envconfig crate eliminates any need for custom error reporting
about which environment variable is missing (which not comes for
free when just using std::env::var)
* The rstest crate conveniently allows to use test fixtures and
supports parametrizing tests which will likely be used by the next
test cases to come
The expected behavior is the same for all platforms. Let's run these test cases everywhere then.
This apparently does not reduce noise in CI but at least allows to build the examples with Rust 1.59.0.
sirhcel
force-pushed
the
more-tests-and-cleanup
branch
from
b71fc0e
to
685324e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the following points:
SerialPorttrait on all platformsIt also adds the first test for read timeouts showing the blocking behavior for a timeout of zero as described in #79 and paves the way for integrating #79.