Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: make sure all run dep are constrained within a major version #173

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

ickc
Copy link
Collaborator

@ickc ickc commented Dec 18, 2020

Just a preventive measure, no need to make release for this.

@ickc
Copy link
Collaborator Author

ickc commented Dec 18, 2020

The error on pypy3: Error: IS_WINDOWS is not defined is unrelated from actions/setup-python#171

Ready to merge.

@sergiocorreia
Copy link
Owner

Merging it, but it's always a tradeoff whether to restrict versions to be at most xyz. For instance, py4 should introduce no major incompatibilities, so it should work well; and perhaps it's the same with click and pyjson.

@sergiocorreia sergiocorreia merged commit 055badc into sergiocorreia:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants