Remove workaround for serde_json's arbitrary_precision feature
#1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past `serde_json` would call `Visitor::visit_map` for all numbers when its `arbitrary_precision` feature is activated. Since `serde_json` v1.0.75 that method is only called for 128bit numbers.
arqunis
added
enhancement
arqunis
approved these changes
Jan 18, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 23, 2022
…enity-rs#1669) In the past `serde_json` would call `Visitor::visit_map` for all numbers when its `arbitrary_precision` feature is activated. Since `serde_json` v1.0.75 that method is only called for 128bit numbers.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Mar 1, 2022
…enity-rs#1669) In the past `serde_json` would call `Visitor::visit_map` for all numbers when its `arbitrary_precision` feature is activated. Since `serde_json` v1.0.75 that method is only called for 128bit numbers.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Mar 15, 2022
…enity-rs#1669) In the past `serde_json` would call `Visitor::visit_map` for all numbers when its `arbitrary_precision` feature is activated. Since `serde_json` v1.0.75 that method is only called for 128bit numbers.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Apr 2, 2022
…enity-rs#1669) In the past `serde_json` would call `Visitor::visit_map` for all numbers when its `arbitrary_precision` feature is activated. Since `serde_json` v1.0.75 that method is only called for 128bit numbers.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Apr 18, 2022
…enity-rs#1669) In the past `serde_json` would call `Visitor::visit_map` for all numbers when its `arbitrary_precision` feature is activated. Since `serde_json` v1.0.75 that method is only called for 128bit numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past
serde_jsonwould callVisitor::visit_mapfor all numberswhen its
arbitrary_precisionfeature is activated.Since
serde_jsonv1.0.75 that method is only called for 128bit numbers.Original issue: #527
Fix in
serde_json: serde-rs/json#848