Do not write skipped fields in deserialize_in_place() #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3ndrk
force-pushed
the
fix-deserialize_in_place-for-skipped-fields
branch
from
2543484
to
00df531
Compare
|
I rebased to the latest |
h3ndrk
force-pushed
the
fix-deserialize_in_place-for-skipped-fields
branch
from
00df531
to
a111571
Compare
|
I'm also very interested in having this merged, for the same reasons as stated in #2512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR actually skips fields in sequences in
deserialize_in_place()as explained in #2512.Fixes #2512
Formatting didn't work in this file so I formatted manually...