make the explanation show up on GitHub and crates.io #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavianator
reviewed
Jun 30, 2023
CohenArthur
reviewed
Aug 3, 2023
| @@ -24,11 +24,8 @@ You may be looking for: | |||
|
|
|||
| ## Serde in action | |||
|
|
|||
| <details> | |||
| <summary> | |||
| Click to show Cargo.toml. | |||
There was a problem hiding this comment.
Suggested change
| Click to show Cargo.toml. |
I believe this line was used to summarize the details button/link thingy. At the moment it just shows up like regular text in front of the playground link, so it should probably go away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a newbie it is rather challenging to find out what needs to be added to the Cargo.toml file in order for the example to work. The information was already in the readme file, but it was hidden both in the default display of the README.md on GitHub and on crates.io