Fix roundtrip of enum with skipped variant #2293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On enums with a skipped variant that is not the last one, the generated serialization and deserialization code map the variants of the enum to different variant indices. In `deserialize_identifier`, the variant index starts at 0 and counts up once per non-skipped variant. However, for serialization the index is always the index of the variant within the enum. This PR corrects the deserialization code to always use the index of the variant within the enum. This was surfaced in jamesmunns/postcard#79.
XBagon
reviewed
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On enums with a skipped variant that is not the last one, the generated serialization and deserialization code map the variants of the enum to different variant indices. In
deserialize_identifier, the variant index starts at 0 and counts up once per non-skipped variant. However, for serialization the index is always the index of the variant within the enum.This PR corrects the deserialization code to always use the index of the variant within the enum.
This was surfaced in jamesmunns/postcard#79.