Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unaligned reference warnings on packed remote def #2079

Merged
merged 2 commits into from Aug 23, 2021

Commits on Aug 23, 2021

  1. Add test of remote with a packed struct

    Currently fails to build:
    
        error: reference to packed field is unaligned
           --> test_suite/tests/test_gen.rs:858:10
            |
        858 | #[derive(Serialize, Deserialize)]
            |          ^^^^^^^^^
            |
        note: the lint level is defined here
           --> test_suite/tests/test_gen.rs:5:9
            |
        5   | #![deny(warnings)]
            |         ^^^^^^^^
            = note: `#[deny(unaligned_references)]` implied by `#[deny(warnings)]`
            = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
            = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
            = note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info)
    
        error: reference to packed field is unaligned
           --> test_suite/tests/test_gen.rs:858:21
            |
        858 | #[derive(Serialize, Deserialize)]
            |                     ^^^^^^^^^^^
            |
            = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
            = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
            = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
    dtolnay committed Aug 23, 2021
    Copy the full SHA
    14accf7 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    54102ee View commit details
    Browse the repository at this point in the history