Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable 128bit on emscripten target #2049

Closed
wants to merge 1 commit into from
Closed

enable 128bit on emscripten target #2049

wants to merge 1 commit into from

Conversation

extrawurst
Copy link

closes #1995

dtolnay
dtolnay requested changes Jun 29, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable this only on compiler versions that support it. Old compilers probably still don't support 128 bit on emscripten right?

@extrawurst
Copy link
Author

Please enable this only on compiler versions that support it. Old compilers probably still don't support 128 bit on emscripten right?

I would love to do that. I assume you mean the rust version check in the build.rs? is there a way to find out what emscripten version the rust versions are targeting?

@extrawurst extrawurst mentioned this pull request Jun 30, 2021
Closed
@Manishearth Manishearth mentioned this pull request Aug 21, 2021
Merged
@oli-obk
Copy link
Member

oli-obk commented Aug 21, 2021

Please enable this only on compiler versions that support it. Old compilers probably still don't support 128 bit on emscripten right?

I would love to do that. I assume you mean the rust version check in the build.rs? is there a way to find out what emscripten version the rust versions are targeting?

#2076 checks for Rust 1.40, which is when this got supported. I don't think the emscripten version matters

@oli-obk oli-obk closed this Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable integer128 feature for emscripten targets
3 participants
@extrawurst @oli-obk @dtolnay