Add Map::remove_entry #708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay so |
IndexMap has a remove method that is the same as swap_remove, so there is no need to use #[cfg] branching for this.
jplatte
force-pushed
the
map-remove-entry
branch
from
833afc4
to
496ae25
Compare
Which simply calls the same method on the underlying map.
jplatte
force-pushed
the
map-remove-entry
branch
from
496ae25
to
fad1759
Compare
|
@dtolnay It's now behind a feature flag that is also tested on CI. Can you take a look? |
dtolnay
requested changes
Sep 30, 2020
|
No, unfortunately I don't think that is possible. The entry API requires taking ownership of the key which defeats the whole point, and a raw entry API is only available for HashMap, not BTreeMap. |
|
Closing in favor of #712 which emulates the API when remove_entry is not available on the underlying type. |
|
I see, so using a less efficient implementation on older versions. I like that 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and simplify
Map::remove, since I noticed it uses#[cfg]branching when it doesn't need to.