push_to_string #1010
Closed
push_to_string #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe API to use when serde-json is used to serialze values semi-automatically, i.e. half of JSON is written by appending strings to `String`, and and half of serialization is done with `serde-json`.
dtolnay
reviewed
Apr 10, 2023
There was a problem hiding this comment.
I think the intersection of circumstances where someone is appending JSON to an existing string, to_string + push_str is too slow, to_writer + from_utf8 is too slow, and to_writer + from_utf8_unchecked is too unsafe, is too small to make sense adding a function dedicated to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe API to use when serde-json is used to serialze values semi-automatically, i.e. half of JSON is written by appending strings to
String, and and half of serialization is done withserde-json.