This repository has been archived by the owner on May 24, 2023. It is now read-only.
Replaces deprecated prometheus/common/log with Go's built-in log package #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccjenniferhsu
force-pushed
the
deprecate-prom-log-lib
branch
from
b8ad907
to
1ec87ee
Compare
ccjenniferhsu
changed the title
ccjenniferhsu
force-pushed
the
deprecate-prom-log-lib
branch
from
bbc0b9b
to
8ad9269
Compare
ccjenniferhsu
changed the title
|
hey @ccjenniferhsu, I'm creating a fork of this project to keep it more updated with latest versions of Logstash's API and support amd64 and arm64. Do you mind if I merge your work on this new repo? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #31. http://github.com/prometheus/common/log package is deprecated in prometheus/common#306. This PR use go's built-in log package to replace the deprecated logging package