Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(model): Added paranoid option for Model.BelongsToMany.through #276

Closed
wants to merge 2 commits into from

Conversation

ajatdarojat45
Copy link

@ajatdarojat45 ajatdarojat45 commented Sep 29, 2022

Because in Model.BelongsToMany.through documentation there is no paranoid option so i adding it in documentation.

@ephys
Copy link
Member

ephys commented Sep 29, 2022

Thank you for the PR but unfortunately Sequelize 5 has been EOL since last January, and we don't accept any PRs for versions older than v6 (with exceptions for critical security issues)

The file you modified is generated from the source code of Sequelize 5, it has been committed here as an archive - we don't expect it to change anymore.

I invite you to migrate to Sequelize 6 instead, the breaking change list is not very long: https://sequelize.org/docs/v6/other-topics/upgrade/

@ajatdarojat45
Copy link
Author

ajatdarojat45 commented Sep 29, 2022

hi @ephys thank you for your reply to my PR.
To be honest i want to implement my PR in sequelize v6 documentation, but i can not find the sequelize v6 documentation in this repo. can you tell me where is it?

@ephys
Copy link
Member

ephys commented Sep 29, 2022

Of course :)

It's automatically generated from the JSDoc in the sequelize repo: https://github.com/sequelize/website/blob/main/sync-repositories.sh#L41-L47

I recommend cloning the v6 branch of this repository: https://github.com/sequelize/sequelize/tree/v6

Then apply your changes in, I think, this folder: https://github.com/sequelize/sequelize/tree/v6/src/associations (don't forget to update the jsdoc in both .d.ts & .js)

You can then test your changes locally using:

yarn # Install branch deps & build
yarn docs # Generate v6 typedocs (it's a static website)

When ready, open a PR against the v6 branch. Once merged the website will be rebuilt to include the changes! :)

(edit: note that this is for the API reference, if you need to update any guide, then it's this folder https://github.com/sequelize/website/tree/main/versioned_docs/version-6.x.x)

@ajatdarojat45
Copy link
Author

Thank you @ephys, i have added my changes into this repo: https://github.com/sequelize/sequelize/tree/v6
You can review my changes in this PR: sequelize/sequelize#15065
Let me know if you have any questions.

@ajatdarojat45 ajatdarojat45 changed the title Add through.paranoid option on Model.BelongsToMany documentation docs(model): Added paranoid option for Model.BelongsToMany.through Sep 29, 2022
@WikiRik
Copy link
Member

WikiRik commented Sep 29, 2022

Since we have moved to a different PR, I will close this one

@WikiRik WikiRik closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants