Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oracle): bind parameters in random order and/or when used multiple times. #17323

Open
wants to merge 4 commits into
base: v6
Choose a base branch
from

Conversation

tfiliano
Copy link

it fixes the issue #17322

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

By using regex to identify all parameters in the query starting with ":" and getting value by the parameter name and then pushing it into the bindParameters.

So it preserver the right order as the parameters were added to the query

List of Breaking Changes

There are no breaking changes

it fixes the issue [17322]
fix error  Expected a conditional expression and instead saw an assignment  no-cond-assign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant